Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user dropdown menu position on RTL layout #30490

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Sep 25, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Fixes #30094

Steps to test or reproduce

Further comments

TC-950

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: fe938aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #30490 (9e9c02d) into develop (e7cff82) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30490      +/-   ##
===========================================
- Coverage    51.31%   51.26%   -0.06%     
===========================================
  Files          811      805       -6     
  Lines        15081    15106      +25     
  Branches      2753     2761       +8     
===========================================
+ Hits          7739     7744       +5     
- Misses        6933     6940       +7     
- Partials       409      422      +13     
Flag Coverage Δ
e2e 48.57% <ø> (+<0.01%) ⬆️
unit 64.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@guijun13 guijun13 marked this pull request as ready for review September 28, 2023 13:52
@guijun13 guijun13 requested a review from a team as a code owner September 28, 2023 13:52
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 6, 2023
@kodiakhq kodiakhq bot merged commit 3a62ac4 into develop Oct 6, 2023
@kodiakhq kodiakhq bot deleted the fix/ltr-user-menu branch October 6, 2023 20:19
@scuciatto scuciatto added this to the 6.4.1 milestone Oct 9, 2023
gabriellsh added a commit that referenced this pull request Oct 9, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits)
  fix: don't save the filter value on offlineMessageChannelName (#30576)
  feat: New permission to kick users (#30535)
  chore: improve message link focus (#30578)
  chore: Add required visual indication on `EditRoom` name input (#30589)
  fix: user dropdown menu position on RTL layout (#30490)
  chore: add missing `_id` field to `AtLeast` (#30592)
  test: Improve tests for legacy omnichannel analytics  (#30379)
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
  feat: Save visitor's activity on agent's interaction (#30222)
  chore: update mentions upsell modal content (#30503)
  fix: font-disabled color (#30569)
  chore: anchor text-decoration rules (#30485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User menu falls out of the home window in RTL languages
4 participants