fix: Check for room scoped permissions for creating discussions #30497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8f2035 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30497 +/- ##
===========================================
- Coverage 50.87% 50.77% -0.10%
===========================================
Files 809 803 -6
Lines 15021 15014 -7
Branches 2730 2733 +3
===========================================
- Hits 7642 7624 -18
- Misses 6970 6971 +1
- Partials 409 419 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
changed the title
gabriellsh
previously approved these changes
Sep 29, 2023
There was a problem hiding this comment.
I know the discussion message action isn't working rn (or at least it wasn't last time I checked it), but shouldn't we apply that change there too? 🤔
I mean here
gabriellsh
approved these changes
Oct 3, 2023
matheusbsilva137
approved these changes
Oct 3, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 6, 2023
…t into improve/ui-caching * 'improve/ui-caching' of github.com:RocketChat/Rocket.Chat: (40 commits) Update .changeset/wicked-humans-hang.md feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) chore: `AccessibilityPage` hide Enterprise tag when is EE (#30486) chore: Replace `Field.[SUBCOMPONENT]` in favor of named imports (#30501) fix: Check for room scoped permissions for creating discussions (#30497) ci: fix Docker image build for production (#30562) chore: Fix triggers flaky tests (#30530) chore: get translations from CDN (#30331) feat: new `licenses.info` endpoint (#30473) ci: run tests from forks (#30556) regression: unmarked dangling promise on license validation (#30557) regression: fix initializing startup order (#30555) feat: push notification statistics (#30269) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) ...
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SUP-337