fix: use setImmediate to handle username update #30500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12314bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30500 +/- ##
===========================================
- Coverage 51.28% 51.21% -0.08%
===========================================
Files 811 803 -8
Lines 15078 15092 +14
Branches 2754 2765 +11
===========================================
- Hits 7733 7729 -4
- Misses 6935 6939 +4
- Partials 410 424 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
reviewed
Oct 4, 2023
sampaiodiego
requested changes
Oct 6, 2023
There was a problem hiding this comment.
there are more operations on line 71 that should also go to the new function updateUsernameReferences - https://github.com/RocketChat/Rocket.Chat/pull/30500/files?diff=split&w=0#diff-3665ef25f844f29569d95ff6d3acd1574e5e3d37707020c980073f08069306f9R71
sampaiodiego
approved these changes
Oct 6, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 16, 2023
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: feat: add tooltip to badge mentions (#30590) chore: improve `Tag` a11y link (#30636) refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634) fix: Improve FileProxy Handling, set Content-Type (#30427) refactor: `EditRoomInfo` to typescript (#28318) fix: mobile ringing notification missing call id (#30614) fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560) test: More tests for groups kick (#30536) fix: Threads breaking after sending messages too fast (#30622) chore: Remove text decoration from room tag (#30606) i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613) fix: File attachments have no content when exporting room messages as file (#30596) fix: use setImmediate to handle username update (#30500) chore: `AnalyticsReports` visual adequacy (#30617)
sampaiodiego
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When updating a username with many messages and mentions, the request can result in a TimeOut error since the request can take a long time to be finished.
To prevent this, we're executing the username update inside a
setImmediateto avoid blocking the process, doing the username update in the background.Issue(s)
Steps to test or reproduce
Further comments
SUP-248
ADR-60