Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud): Consuming announcements #30506

Closed
wants to merge 12 commits into from

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

* Empty commit

* Add type for synchronization payload

* Splitting fetching and consumption of sync data

* Normalize registration data

* Expand `Cloud.Announcement`

* Add model for cloud announcements

* Validate the payload

* Use `suretype`

* Refactor a bunch of stuff

* Handle announcements on sync

* Fix typo
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: fb72892

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/tools Minor
@rocket.chat/license Minor
@rocket.chat/jwt Minor
@rocket.chat/omnichannel-services Minor
@rocket.chat/omnichannel-transcript Minor
@rocket.chat/authorization-service Minor
@rocket.chat/stream-hub-service Minor
@rocket.chat/presence-service Minor
@rocket.chat/account-service Minor
@rocket.chat/core-services Minor
@rocket.chat/model-typings Minor
@rocket.chat/ddp-streamer Minor
@rocket.chat/queue-worker Minor
@rocket.chat/presence Minor
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/api-client Patch
@rocket.chat/pdf-worker Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #30506 (fb72892) into feat/cloud-announcements (9a6a4dd) will increase coverage by 3.21%.
The diff coverage is 70.47%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feat/cloud-announcements   #30506      +/-   ##
============================================================
+ Coverage                     46.02%   49.24%   +3.21%     
============================================================
  Files                           766      773       +7     
  Lines                         14227    14662     +435     
  Branches                       2612     2645      +33     
============================================================
+ Hits                           6548     7220     +672     
+ Misses                         7281     7049     -232     
+ Partials                        398      393       -5     
Flag Coverage Δ
e2e 46.64% <66.66%> (+2.74%) ⬆️
unit 62.82% <70.97%> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the feat/cloud-announcements branch from f1ddd78 to 56aa8bf Compare September 29, 2023 20:16
Base automatically changed from feat/cloud-announcements to develop September 29, 2023 21:21
@tassoevan tassoevan closed this Oct 18, 2023
@tassoevan tassoevan deleted the feat/cloud-announcements-consumption branch October 18, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant