Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple BH setup page not loading upon server restart #30510

Closed
wants to merge 1 commit into from

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Sep 27, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Note: this issue is only reproducible when running the server in dev environment using yarn dsv command

  1. Set BH to multiple mode
  2. Create at-least one custom BH
  3. Restart the server from Admin -> Settings -> General -> Restart
  4. Upon restart, go to Business hour config page (i.e. Omnichannel -> Business hour)

Expected Behaviour:
See a list of all custom Business hours created

Actual Behaviour:
You only get to see a single business hour which is the default one

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

⚠️ No Changeset found

Latest commit: 8159afb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #30510 (8159afb) into develop (7061b67) will decrease coverage by 0.13%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30510      +/-   ##
===========================================
- Coverage    50.23%   50.11%   -0.13%     
===========================================
  Files          780      779       -1     
  Lines        14476    14489      +13     
  Branches      2617     2620       +3     
===========================================
- Hits          7272     7261      -11     
- Misses        6809     6824      +15     
- Partials       395      404       +9     
Flag Coverage Δ
e2e 48.47% <100.00%> (-0.13%) ⬇️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98
Copy link
Contributor Author

Closing since this fix is being applied here #30565

@murtaza98 murtaza98 closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant