test: refactor API E2E tests for groups endpoints #30523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #30523 +/- ##
===========================================
- Coverage 50.93% 50.77% -0.17%
===========================================
Files 809 803 -6
Lines 15016 14995 -21
Branches 2724 2720 -4
===========================================
- Hits 7649 7614 -35
- Misses 6958 6960 +2
- Partials 409 421 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
ggazzo
reviewed
Sep 29, 2023
ggazzo
reviewed
Sep 29, 2023
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
Sep 30, 2023
This was referenced Sep 30, 2023
gabriellsh
added a commit
that referenced
this pull request
Oct 3, 2023
…e/translationCdn * 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) chore: adjust callbacks return type (#30547) chore: Delete Trigger Endpoint (#30533) test: adding missing verifications on message-actions (#30531) refactor: Oembed backend (#30228) test: refactor API E2E tests for groups endpoints (#30523) test: adding missing verifications on threads (#30528) chore: refactor cloud sync (#30401) refactor: Omni logs (#30322) refactor: Livechat Header -> ts (#30255) chore: Deprecate un-used meteor method for omnichannel analytics (#30421) feat: add supported versions + minimum clients versions to the info endpoint (#30178) feat: Auto-enable autotranslate (#30370) chore: Prevent call license and registration status endpoints when not enough permission (#30336) ci: Security/GitHub jira integration (#29776) feat: License V3 (#30287) chore: move Omnichannel toolbox section from sidebar room list (#30502) ...
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
I needed to add a few new tests and realised the whole file was being executed in many weird ways. So I refactor it to use
describecorrectly for each endpoint. I also added a few clean up routines but it is still not covering all tests.Some tests were depending on the setting
E2E_Enableto be set astrue, but I don't know how they were "working" since it was not being set anymore. This issue started to happen when I useddescribefor all tests. I wonder if some failures were hidden previsouly.Issue(s)
Steps to test or reproduce
Further comments