Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(uikit): uikit interactions #30534

Merged
merged 13 commits into from
Oct 19, 2023
Merged

refactor(uikit): uikit interactions #30534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dc229ef
Keep tuples' structure when using `Serialized`
tassoevan Sep 28, 2023
1858477
Type `UiKitModal` props
tassoevan Sep 29, 2023
fe46bc8
Add `Promise.prototype.finally` polyfill
tassoevan Oct 6, 2023
f65651f
Add `preventSyntheticEvent`
tassoevan Oct 6, 2023
f6e48e6
Add `DistributiveOmit<T, K>`
tassoevan Oct 6, 2023
7ec81cc
Type UiKit payloads for core apps
tassoevan Oct 7, 2023
d4d8775
Upgrade turborepo
tassoevan Oct 7, 2023
e5578ce
Type UiKit user interactions
tassoevan Oct 11, 2023
94f51f9
Start migrating Action Manager to TS
tassoevan Oct 11, 2023
ed9ada7
Redesign `ActionManager`
tassoevan Oct 13, 2023
d04366f
Fix runtime
tassoevan Oct 18, 2023
7504aca
Replace some types
tassoevan Oct 18, 2023
3b907d8
Revert base class
tassoevan Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/meteor/app/apps/server/bridges/uiInteraction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import type { IUIKitInteraction } from '@rocket.chat/apps-engine/definition/uikit';
import type { IUser } from '@rocket.chat/apps-engine/definition/users';
import { UiInteractionBridge as UiIntBridge } from '@rocket.chat/apps-engine/server/bridges/UiInteractionBridge';
import { UiInteractionBridge as AppsEngineUiInteractionBridge } from '@rocket.chat/apps-engine/server/bridges/UiInteractionBridge';
import { api } from '@rocket.chat/core-services';
import type { UiKit } from '@rocket.chat/core-typings';

import type { AppServerOrchestrator } from '../../../../ee/server/apps/orchestrator';

export class UiInteractionBridge extends UiIntBridge {
export class UiInteractionBridge extends AppsEngineUiInteractionBridge {
constructor(private readonly orch: AppServerOrchestrator) {
super();
}
Expand All @@ -19,6 +20,6 @@ export class UiInteractionBridge extends UiIntBridge {
throw new Error('Invalid app provided');
}

void api.broadcast('notify.uiInteraction', user.id, interaction);
void api.broadcast('notify.uiInteraction', user.id, interaction as UiKit.ServerInteraction);
}
}
261 changes: 0 additions & 261 deletions apps/meteor/app/ui-message/client/ActionManager.js
View file
Open in desktop

This file was deleted.

Loading
Loading