-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Count daily and monthly peaks of concurrent connections #30573
Conversation
🦋 Changeset detectedLatest commit: ae10d1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30573 +/- ##
===========================================
- Coverage 51.29% 51.15% -0.15%
===========================================
Files 811 805 -6
Lines 15059 15074 +15
Branches 2751 2785 +34
===========================================
- Hits 7725 7711 -14
- Misses 6926 6929 +3
- Partials 408 434 +26
Flags with carried forward coverage won't be shown. Click here to find out more. |
I've made a few changes to the PR.. removed the previously created new endpoint in favor of adding the values to the statistics.. 👍 |
We need to state clearly that this only works for single instance deployments since it does not sum the count of connections among instances. |
@rodrigok this is not true.. it does count connections from all instances.. each instance store the concurrent connections to their record into the |
Proposed changes (including videos or screenshots)
dailyPeakConnections
statistic for monitoring the daily peak of concurrent connections in a workspace;maxMonthlyPeakConnections
statistic for monitoring the last 30 days peak of concurrent connections in a workspace;Issue(s)
Steps to test or reproduce
presence.getConnections
endpoint (the value generated for thedailyPeakConnections
statistic is the highest value that could be returned by this endpoint since the last time the statistics were saved via cronjob).Further comments
NBJ-416