Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove text decoration from room tag #30606

Merged
merged 3 commits into from
Oct 11, 2023
Merged

chore: Remove text decoration from room tag #30606

merged 3 commits into from
Oct 11, 2023

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Screen Shot 2023-10-09 at 11 46 57Screen Shot 2023-10-09 at 11 47 40

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: 69832bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #30606 (69832bd) into develop (0cdf97d) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30606      +/-   ##
===========================================
- Coverage    51.28%   51.00%   -0.29%     
===========================================
  Files          811      804       -7     
  Lines        15078    15107      +29     
  Branches      2754     2768      +14     
===========================================
- Hits          7733     7705      -28     
- Misses        6935     6975      +40     
- Partials       410      427      +17     
Flag Coverage Δ
e2e 48.27% <ø> (-0.29%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review October 11, 2023 21:54
@juliajforesti juliajforesti requested a review from a team as a code owner October 11, 2023 21:54
@dougfabris dougfabris added this to the 6.5.0 milestone Oct 11, 2023
@dougfabris dougfabris changed the title chore: remove text decoration from room tag chore: Remove text decoration from room tag Oct 11, 2023
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a workaround looks approvable to me!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 11, 2023
@kodiakhq kodiakhq bot merged commit 82839a4 into develop Oct 11, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the chore/room-tag branch October 11, 2023 22:46
gabriellsh added a commit that referenced this pull request Oct 16, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  feat: add tooltip to badge mentions (#30590)
  chore: improve `Tag` a11y link (#30636)
  refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634)
  fix: Improve FileProxy Handling, set Content-Type (#30427)
  refactor: `EditRoomInfo` to typescript (#28318)
  fix: mobile ringing notification missing call id (#30614)
  fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560)
  test: More tests for groups kick (#30536)
  fix: Threads breaking after sending messages too fast (#30622)
  chore: Remove text decoration from room tag (#30606)
  i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613)
  fix: File attachments have no content when exporting room messages as file (#30596)
  fix: use setImmediate to handle username update (#30500)
  chore: `AnalyticsReports` visual adequacy (#30617)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants