fix: Read receipts are not created on the first time a user reads a room #30610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f0852a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30610 +/- ##
===========================================
- Coverage 51.29% 51.01% -0.29%
===========================================
Files 811 805 -6
Lines 15062 15077 +15
Branches 2753 2787 +34
===========================================
- Hits 7726 7691 -35
- Misses 6928 6954 +26
- Partials 408 432 +24
Flags with carried forward coverage won't be shown. Click here to find out more. |
…com/RocketChat/Rocket.Chat into fix/receipts-not-created-first-read
sampaiodiego
previously approved these changes
Oct 13, 2023
heitortanoue
previously approved these changes
Oct 13, 2023
matheusbsilva137
dismissed stale reviews from heitortanoue and sampaiodiego
via
dde591c
There was a problem hiding this comment.
QA noticed that when creating a room already with a member, the first messages would still not be marked as read when reading the room with the invited user (that's because we update their subscription by the time the first message is sent, which makes _updatedAt timestamp bigger than the message's ts). That's now fixed by using the subscription's ts instead
Thanks @jessicaschelly
heitortanoue
approved these changes
Oct 13, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
heitortanoue
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 18, 2023
…chat.postMessage * 'develop' of github.com:RocketChat/Rocket.Chat: fix: inconsistent behavior when removing subscriptions and inquiries (#30572) fix: Handle AWS S3 Re-Authentication via s3.getSignedUrlPromise (#30642) test: wait for the name update finish (#30663) regression: Restore default limits to community apps (#30611) refactor: Move functions out of `Livechat.js` (#30650) chore: remove license v3 public key envvar (#30646) fix: Read receipts are not created on the first time a user reads a room (#30610) fix: licenses.info endpoint only available for admins (#30644)
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
…oom (#30610) Co-authored-by: Heitor Tanoue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
TC-986