Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Restore default limits to community apps #30611

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 10, 2023

NBJ-422

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: c34e351

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 6.5.0 milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #30611 (c34e351) into develop (85ddfb2) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30611      +/-   ##
===========================================
- Coverage    51.29%   51.01%   -0.28%     
===========================================
  Files          811      805       -6     
  Lines        15062    15077      +15     
  Branches      2753     2787      +34     
===========================================
- Hits          7726     7692      -34     
- Misses        6928     6953      +25     
- Partials       408      432      +24     
Flag Coverage Δ
e2e 48.31% <ø> (-0.26%) ⬇️
unit 64.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review October 17, 2023 07:27
@ggazzo ggazzo merged commit 3b5310c into develop Oct 18, 2023
41 checks passed
@ggazzo ggazzo deleted the regression/apps-limits branch October 18, 2023 12:48
gabriellsh added a commit that referenced this pull request Oct 18, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: inconsistent behavior when removing subscriptions and inquiries (#30572)
  fix: Handle AWS S3 Re-Authentication via s3.getSignedUrlPromise (#30642)
  test: wait for the name update finish (#30663)
  regression: Restore default limits to community apps (#30611)
  refactor: Move functions out of `Livechat.js` (#30650)
  chore: remove license v3 public key envvar (#30646)
  fix: Read receipts are not created on the first time a user reads a room (#30610)
  fix: licenses.info endpoint only available for admins (#30644)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants