Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pagination & tooltips to agent's dropdown on forwarding modal #30629

Merged
merged 23 commits into from
Oct 23, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Oct 12, 2023

Proposed changes (including videos or screenshots)

Issue(s)

SUP-384
OC-1322

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 13d9270

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #30629 (13d9270) into develop (b98b99e) will decrease coverage by 0.24%.
Report is 2 commits behind head on develop.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30629      +/-   ##
===========================================
- Coverage    51.23%   50.99%   -0.24%     
===========================================
  Files          811      809       -2     
  Lines        15121    15222     +101     
  Branches      2764     2828      +64     
===========================================
+ Hits          7747     7763      +16     
- Misses        6962     7018      +56     
- Partials       412      441      +29     
Flag Coverage Δ
e2e 48.27% <33.33%> (-0.21%) ⬇️
unit 63.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the chore/agents-endpoint-public branch from ec23494 to 0ca888d Compare October 16, 2023 13:57
@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 16, 2023 15:58
@MartinSchoeler MartinSchoeler requested review from a team as code owners October 16, 2023 15:58
MartinSchoeler
MartinSchoeler previously approved these changes Oct 16, 2023
sampaiodiego
sampaiodiego previously approved these changes Oct 17, 2023
@renatobecker renatobecker added this to the 6.4.3 milestone Oct 19, 2023
@aleksandernsilva aleksandernsilva dismissed stale reviews from sampaiodiego and themself via 0b0cf53 October 19, 2023 17:25
@casalsgh casalsgh requested a review from sampaiodiego October 20, 2023 15:09
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 20, 2023
@KevLehman KevLehman changed the title chore: Use users/agent endpoint in forwarding modals feat: Add pagination & tooltips to agent's dropdown on forwarding modal Oct 20, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 20, 2023
sampaiodiego
sampaiodiego previously approved these changes Oct 20, 2023
@aleksandernsilva aleksandernsilva dismissed stale reviews from sampaiodiego and themself via 99d412d October 20, 2023 20:51
@casalsgh casalsgh added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2023
@casalsgh casalsgh requested a review from sampaiodiego October 23, 2023 12:56
@ggazzo ggazzo merged commit a82d8c2 into develop Oct 23, 2023
44 checks passed
@ggazzo ggazzo deleted the chore/agents-endpoint-public branch October 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants