-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: read receipts #30637
test: read receipts #30637
Conversation
…com/RocketChat/Rocket.Chat into fix/receipts-not-created-first-read
🦋 Changeset detectedLatest commit: 91f8410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30637 +/- ##
===========================================
- Coverage 51.34% 51.14% -0.20%
===========================================
Files 815 815
Lines 15121 15271 +150
Branches 2754 2834 +80
===========================================
+ Hits 7764 7811 +47
- Misses 6948 7020 +72
- Partials 409 440 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need multiple describe
sections for all situations you're testing, each one with their own messages in the correct state.
1 - simple message and thread that nobody has read yet
2 - simple message and thread where the room message was read by another user but the thread message was not
3 - another test where everything was read by both users
4 - another test that checks the result of getReadReceipts
after the call to readThreads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid calling expect
inside the before
section of tests; if the call fails the test will fail anyway.
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Proposed changes (including videos or screenshots)
Create a new file dedicated to the read-receipts feature tests and improve its coverage (including some edge-cases introduced in the last major release).
Issue(s)
Steps to test or reproduce
Further comments
TC-502