refactor: Move functions out of Livechat.js
#30650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #30650 +/- ##
===========================================
- Coverage 51.29% 51.13% -0.17%
===========================================
Files 811 805 -6
Lines 15062 15077 +15
Branches 2752 2786 +34
===========================================
- Hits 7726 7709 -17
- Misses 6928 6933 +5
- Partials 408 435 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
approved these changes
Oct 17, 2023
dionisio-bot
bot
added
stat: ready to merge
aleksandernsilva
approved these changes
Oct 17, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
d-gubert
approved these changes
Oct 17, 2023
KevLehman
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 18, 2023
…chat.postMessage * 'develop' of github.com:RocketChat/Rocket.Chat: fix: inconsistent behavior when removing subscriptions and inquiries (#30572) fix: Handle AWS S3 Re-Authentication via s3.getSignedUrlPromise (#30642) test: wait for the name update finish (#30663) regression: Restore default limits to community apps (#30611) refactor: Move functions out of `Livechat.js` (#30650) chore: remove license v3 public key envvar (#30646) fix: Read receipts are not created on the first time a user reads a room (#30610) fix: licenses.info endpoint only available for admins (#30644)
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments