Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add VSCode extensions recommendations #30655

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: Add VSCode extensions recommendations #30655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"recommendations": [
"streetsidesoftware.code-spell-checker",
"streetsidesoftware.code-spell-checker-portuguese-brazilian",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "streetsidesoftware.code-spell-checker-portuguese-brazilian", is necessary? Since our codebase is written in English? I would suggest remove it.

Suggested change
"streetsidesoftware.code-spell-checker-portuguese-brazilian",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helps on translation files. We probably should have for every official supported language.

"editorconfig.editorconfig",
"dbaeumer.vscode-eslint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright VS code extension is a very useful tool to debug and write tests

Suggested change
"dbaeumer.vscode-eslint",
"dbaeumer.vscode-eslint",
"ms-playwright.playwright",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think playwright is more situational. For example, BE devs won't use it :trollface:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Kevin.

But also doesn't hurt. Playwright is used a lot in the project so i think makes sense to include. Anyone not wanting can ignore.

"eamodio.gitlens"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add esbenp.prettier-vscode too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might conflict with the ESLint one.

]
}
Loading