Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Call api only once when sharing a message #30656

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 17, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Depends of #30652

@gabriellsh gabriellsh requested a review from a team as a code owner October 17, 2023 16:16
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: 103a385

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #30656 (103a385) into develop (ba16e50) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30656      +/-   ##
===========================================
- Coverage    51.22%   50.92%   -0.31%     
===========================================
  Files          811      808       -3     
  Lines        15114    15208      +94     
  Branches      2758     2827      +69     
===========================================
+ Hits          7742     7744       +2     
- Misses        6961     7021      +60     
- Partials       411      443      +32     
Flag Coverage Δ
e2e 48.17% <ø> (-0.31%) ⬇️
unit 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch my friend ❤️

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 26, 2023
@kodiakhq kodiakhq bot merged commit 356a7b1 into develop Oct 26, 2023
44 checks passed
@kodiakhq kodiakhq bot deleted the fix/shareMessage branch October 26, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants