Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI issue on marketplace filters #30660

Merged
merged 11 commits into from
Oct 19, 2023

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Oct 17, 2023

Proposed changes (including videos or screenshots)

Current:
image

image

Fixed:
image

image

Issue(s)

https://rocketchat.atlassian.net/browse/AECO-352

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: d2f8089

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #30660 (d2f8089) into develop (93a0859) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30660      +/-   ##
===========================================
- Coverage    51.19%   51.05%   -0.14%     
===========================================
  Files          811      809       -2     
  Lines        15059    15158      +99     
  Branches      2750     2812      +62     
===========================================
+ Hits          7709     7739      +30     
- Misses        6940     6981      +41     
- Partials       410      438      +28     
Flag Coverage Δ
e2e 48.38% <ø> (-0.12%) ⬇️
unit 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review October 17, 2023 19:57
@csuadev csuadev requested a review from a team as a code owner October 17, 2023 19:57
@juliajforesti juliajforesti changed the title chore: fix UI issue on marketplace filters fix: UI issue on marketplace filters Oct 18, 2023
csuadev and others added 3 commits October 18, 2023 15:55
…/CategoryDropDownAnchor.tsx

Co-authored-by: Júlia Jaeger Foresti <[email protected]>
…/CategoryDropDownAnchor.tsx

Co-authored-by: Júlia Jaeger Foresti <[email protected]>
…RadioDownAnchor.tsx

Co-authored-by: Júlia Jaeger Foresti <[email protected]>
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@kodiakhq kodiakhq bot merged commit b85df55 into develop Oct 19, 2023
38 checks passed
@kodiakhq kodiakhq bot deleted the chore/AECO-352-fix-marketplace-filters-ui branch October 19, 2023 21:46
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@casalsgh casalsgh added this to the 6.5.0 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: apps ecosystem AECO stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants