Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove enableQuery from Accounts_EmailVerification #30686

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 19, 2023

Proposed changes (including videos or screenshots)

Remove the enableQuery from the setting Accounts_EmailVerification to allow SaaS environments to enable or disable this option.
Since the SMTP_Host setting is hidden from the client side in SaaS environments, the option to only allow verified users to log in is disabled incorrectly.

Issue(s)

Steps to test or reproduce

Further comments

SUP-340

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: c114095

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #30686 (c114095) into develop (6190c92) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30686      +/-   ##
===========================================
- Coverage    51.22%   51.08%   -0.14%     
===========================================
  Files          811      809       -2     
  Lines        15113    15218     +105     
  Branches      2759     2827      +68     
===========================================
+ Hits          7741     7774      +33     
- Misses        6961     7000      +39     
- Partials       411      444      +33     
Flag Coverage Δ
e2e 48.38% <ø> (-0.11%) ⬇️
unit 63.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review October 19, 2023 19:38
@tapiarafael tapiarafael requested a review from a team as a code owner October 19, 2023 19:38
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 23, 2023
@kodiakhq kodiakhq bot merged commit ad7e52b into develop Oct 23, 2023
42 checks passed
@kodiakhq kodiakhq bot deleted the fix/accounts-email-verification branch October 23, 2023 21:41
@casalsgh casalsgh added this to the 6.5.0 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants