-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove enableQuery from Accounts_EmailVerification #30686
Conversation
🦋 Changeset detectedLatest commit: c114095 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30686 +/- ##
===========================================
- Coverage 51.22% 51.08% -0.14%
===========================================
Files 811 809 -2
Lines 15113 15218 +105
Branches 2759 2827 +68
===========================================
+ Hits 7741 7774 +33
- Misses 6961 7000 +39
- Partials 411 444 +33
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Remove the
enableQuery
from the settingAccounts_EmailVerification
to allow SaaS environments to enable or disable this option.Since the
SMTP_Host
setting is hidden from the client side in SaaS environments, the option to only allow verified users to log in is disabled incorrectly.Issue(s)
Steps to test or reproduce
Further comments
SUP-340