-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Message mentions displayed in the UI are outdated after changing username #30774
Conversation
🦋 Changeset detectedLatest commit: 1d3a745 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…m/RocketChat/Rocket.Chat into fix/refresh-md-on-username-change
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #30774 +/- ##
============================================
+ Coverage 49.57% 76.72% +27.14%
============================================
Files 3315 277 -3038
Lines 81425 8963 -72462
Branches 16707 1695 -15012
============================================
- Hits 40369 6877 -33492
+ Misses 36338 1662 -34676
+ Partials 4718 424 -4294
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heitortanoue Can we add some tests to cover this case and prevent that from happening in the future? We can create it in a separate PR if you prefer.
5672df3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code for this approach LGTM. We just gotta check if Architecture thinks we can move on with this one or if they have any other suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. We just need to check if this approach looks fine to Architecture
Proposed changes (including videos or screenshots)
Reparse the markdown (
md
) field when updating messages that mention the username changed.Issue(s)
Steps to test or reproduce
(test also the
DISABLE_MESSAGE_PARSER
env config to see if it is correctly disabling the parsing)Further comments
SUP-378