Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: wrong app limits displayed on the UI #30840

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Nov 2, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: 892047a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo requested a review from d-gubert November 2, 2023 18:48
@ggazzo ggazzo force-pushed the regression/visual-apps-restriction branch from 0157781 to 26db958 Compare November 2, 2023 18:56
@ggazzo ggazzo marked this pull request as ready for review November 2, 2023 18:56
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #30840 (892047a) into develop (9c5ff3e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30840      +/-   ##
===========================================
+ Coverage    51.21%   51.25%   +0.03%     
===========================================
  Files          814      812       -2     
  Lines        15050    15223     +173     
  Branches      2732     2815      +83     
===========================================
+ Hits          7708     7802      +94     
- Misses        6933     6981      +48     
- Partials       409      440      +31     
Flag Coverage Δ
e2e 48.30% <ø> (-0.18%) ⬇️
unit 65.84% <100.00%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title regression: wrong limits displayed on the UI regression: wrong app limits displayed on the UI Nov 2, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 2, 2023
@kodiakhq kodiakhq bot merged commit 4ed60c4 into develop Nov 2, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the regression/visual-apps-restriction branch November 2, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants