Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored current chats e2e tests #31100

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Nov 29, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1395

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 47db029

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #31100 (47db029) into chore/oc-e2e-tests (91c3341) will decrease coverage by 8.71%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           chore/oc-e2e-tests   #31100      +/-   ##
======================================================
- Coverage               57.77%   49.07%   -8.71%     
======================================================
  Files                     885     3295    +2410     
  Lines                   20228    80601   +60373     
  Branches                 3766    16382   +12616     
======================================================
+ Hits                    11687    39551   +27864     
- Misses                   7848    36432   +28584     
- Partials                  693     4618    +3925     
Flag Coverage Δ
e2e 51.94% <100.00%> (+9.57%) ⬆️
e2e-api 40.68% <ø> (?)
unit 77.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the chore/current-chats-e2e-tests branch from 06c97ed to c4c2ab5 Compare November 30, 2023 16:49
@aleksandernsilva aleksandernsilva changed the base branch from develop to chore/oc-dpesp-e2e-tests November 30, 2023 16:50
@aleksandernsilva aleksandernsilva force-pushed the chore/current-chats-e2e-tests branch from c4c2ab5 to 09c6f56 Compare November 30, 2023 17:36
@aleksandernsilva aleksandernsilva changed the base branch from chore/oc-dpesp-e2e-tests to chore/oc-e2e-tests November 30, 2023 18:58
@aleksandernsilva aleksandernsilva force-pushed the chore/current-chats-e2e-tests branch from ec42b6c to 47db029 Compare December 7, 2023 15:05
@aleksandernsilva aleksandernsilva marked this pull request as ready for review December 7, 2023 16:14
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner December 7, 2023 16:14
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 7, 2023
@aleksandernsilva aleksandernsilva merged commit d52d559 into chore/oc-e2e-tests Dec 7, 2023
45 of 46 checks passed
@aleksandernsilva aleksandernsilva deleted the chore/current-chats-e2e-tests branch December 7, 2023 16:16
aleksandernsilva added a commit that referenced this pull request Dec 7, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
aleksandernsilva added a commit that referenced this pull request Dec 12, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added necessary id's for current chats e2e tests

* chore: methods to test current chats, on hold and return button

* chore: renamed take chat button locator

* chore: current chats page object

* chore: refactored current chats e2e tests

* chore: skipping test on community edition

* chore: allow agent to place room on hold

* chore: allow agent to place room on hold without engaging

* chore: queued conversation adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants