feat!: Add permissions to create rooms in teams

[matheusbsilva137]

Proposed changes (including videos or screenshots)

• Add create-team-channel and create-team-group permissions to provide more control for the creation of rooms inside teams (the new permissions are checked within the team's main room scope);
• Update client to use the new permissions within the team's main room scope;
• Fix client to use existing team rooms' editing permissions within the team's main room scope (since auto-join and "remove team channel" options were being incorrectly displayed to room owners that are not team owners/moderators).

Issue(s)

Steps to test or reproduce

Further comments

This is a BREAKING CHANGE
SUP-356

[changeset-bot]

🦋 Changeset detected

Latest commit: 5e395a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@286e1e0). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.0.0   #31117   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           

Flag	Coverage Δ
unit	74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[pierre-lehnen-rc]

One "problem" with this feature is that team owners will be able to create rooms inside teams, but there won't be any way for them to delete those rooms unless they have the global delete permission. Ideally anyone who can create a room should be able to also delete it afterwards.

But in this case we can't simply add a delete-team-channel permission either, because team owners would then be able to delete any global room by simply adding it to their team first.

I don't know what the ideal solution is, but I believe it's just a matter of time until we get people requesting a delete-team-channel permission after this one is merged.

[matheusbsilva137]

@pierre-lehnen-rc with the PR as it is right now, users who have the new permission to add channels/groups would only be able to delete the channels they own (since we check the delete-c and delete-p permissions in the deleted room scope).

I thought of two ways these two new delete-team-channel / delete-team-group permissions could behave if we introduce them:

• They could "override" the global permissions, so that anyone that has this permission in a team would be able to delete ANY room in it (even the ones they don't own);
• They could complement the permission to delete a room. So a user would only be able to delete a room that is part of a team if they own it (delete-c/delete-p permissions, which are currently checked within the deleted room's scope) and are also allowed to delete it in the team.

I'll check what's the behavior we'd like to have in the product. Maybe we should also make this clear somewhere if we decide to implement it.

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.