Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace IconButton in favor of Button on PageHeader #31171

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 6, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

DSAR-382

Copy link

changeset-bot bot commented Dec 6, 2023

⚠️ No Changeset found

Latest commit: fd2fea0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #31171 (fd2fea0) into develop (40e5d4d) will decrease coverage by 8.41%.
Report is 2 commits behind head on develop.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31171      +/-   ##
===========================================
- Coverage    57.24%   48.84%   -8.41%     
===========================================
  Files          881     3274    +2393     
  Lines        19949    80253   +60304     
  Branches      3719    16317   +12598     
===========================================
+ Hits         11419    39196   +27777     
- Misses        7841    36441   +28600     
- Partials       689     4616    +3927     
Flag Coverage Δ
e2e 51.29% <66.66%> (+8.93%) ⬆️
e2e-api 40.66% <ø> (?)
unit 77.37% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 6, 2023 21:41
@dougfabris dougfabris requested review from a team as code owners December 6, 2023 21:41
@ggazzo ggazzo merged commit 3f4b430 into develop Dec 6, 2023
45 of 46 checks passed
@ggazzo ggazzo deleted the chore/replace-back-button branch December 6, 2023 21:50
gabriellsh added a commit that referenced this pull request Dec 7, 2023
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  chore: Rename useFileInput to useSingleFileInput (#31186)
  regression: FED-116 allow to invite rc users to fed channels (#30658)
  refactor: Remove `livechat.js` file (#31179)
  test: Fix Analytics test to use always same date (#31178)
  chore: notify messages on emails incoming and outgoing (#30925)
  chore: add msg stream to the federation v1 feature (#31105)
  chore: update editedBy when the user changes their username (following BE rules) (#31098)
  chore: add a manual msg stream update for autotranslate (#31094)
  chore: send streaming msg update on livechat decline call event (#31025)
  chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171)
  refactor: Migrate `analytics.js` to service (#31051)
  feat: Add `push.info` endpoint to retrieve push gateway info (#30868)
  chore: Convert Importer classes to typescript (#29714)
  docs: fix lost image render in markdown (#31013)
  feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo (#31138)
  i18n: Language update from LingoHub 🤖 on 2023-12-05Z (#31161)
  feat: Skip to main content shortcut and `useDocumentTitle` (#30680)
  chore: Replace `useForm` in favor of RHF on Omnichannel `AgentsEdit` (#30789)
  chore: ImageGallery tweaks (#31159)
  fix: New `custom-roles` license module isn't properly checked (#31153)
  ...
@dougfabris dougfabris added this to the 6.6 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants