Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Field normalization #31182

Merged
merged 11 commits into from
Dec 13, 2023
Merged

chore: Field normalization #31182

merged 11 commits into from
Dec 13, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

DSAR-381

Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: b6fc52f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #31182 (b6fc52f) into develop (1bcb57c) will decrease coverage by 18.73%.
The diff coverage is 69.48%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31182       +/-   ##
============================================
- Coverage    77.38%   58.66%   -18.73%     
============================================
  Files          276     1753     +1477     
  Lines         8715    33986    +25271     
  Branches      1607     7026     +5419     
============================================
+ Hits          6744    19937    +13193     
- Misses        1565    12486    +10921     
- Partials       406     1563     +1157     
Flag Coverage Δ
e2e 51.45% <69.48%> (∅)
unit 77.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 11, 2023 21:15
@dougfabris dougfabris requested review from a team as code owners December 11, 2023 21:15
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 11, 2023
Copy link
Contributor

kodiakhq bot commented Dec 11, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 11, 2023
ggazzo
ggazzo previously approved these changes Dec 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Dec 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 12, 2023
@dougfabris dougfabris force-pushed the chore/field-normalization branch from 27af9b4 to 7dc80f1 Compare December 12, 2023 20:11
@dougfabris dougfabris force-pushed the chore/field-normalization branch from 7dc80f1 to 5ddc404 Compare December 12, 2023 21:31
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Dec 13, 2023
@ggazzo ggazzo merged commit bfbfb8b into develop Dec 13, 2023
43 of 44 checks passed
@ggazzo ggazzo deleted the chore/field-normalization branch December 13, 2023 15:43
gabriellsh added a commit that referenced this pull request Dec 13, 2023
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: `Field` normalization (#31182)
  refactor: `Conversations` Overview Analytics (#31217)
  fix: Notifications for thread messages are sent even after thread has been read (#31181)
  ci: remove carryforward from codecov (#31216)
  fix: Wrong sysmessage when resuming chat from on hold (#31205)
  fix: Gallery not working inside threads (#31213)
@dougfabris dougfabris added this to the 6.6 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants