Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop using callbacks for parsing mentions on messages #31188

Merged
merged 17 commits into from
Dec 18, 2023

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1249

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: ab42e0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego force-pushed the chore-stop-using-callbacks-for-mentions branch from 3dc9ebe to e3d82e2 Compare December 7, 2023 19:32
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #31188 (ab42e0d) into develop (ca2f4c5) will increase coverage by 9.99%.
The diff coverage is 94.28%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31188      +/-   ##
===========================================
+ Coverage    49.33%   59.33%   +9.99%     
===========================================
  Files         3299     1782    -1517     
  Lines        81080    34721   -46359     
  Branches     16554     7208    -9346     
===========================================
- Hits         40000    20601   -19399     
+ Misses       36427    12543   -23884     
+ Partials      4653     1577    -3076     
Flag Coverage Δ
e2e 52.54% <24.59%> (-0.11%) ⬇️
e2e-api ?
unit 76.39% <85.57%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 11, 2023
@sampaiodiego sampaiodiego marked this pull request as ready for review December 11, 2023 14:22
@sampaiodiego sampaiodiego requested review from a team as code owners December 11, 2023 14:22
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 13, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 14, 2023
Copy link
Contributor

kodiakhq bot commented Dec 14, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2023
Copy link
Contributor

kodiakhq bot commented Dec 15, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo merged commit 4a7411b into develop Dec 18, 2023
43 checks passed
@ggazzo ggazzo deleted the chore-stop-using-callbacks-for-mentions branch December 18, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants