-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove @rocket.chat/license from ddp-client deps #31189
Conversation
|
b7cdf2f
to
2db46e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #31189 +/- ##
===========================================
- Coverage 57.77% 48.88% -8.90%
===========================================
Files 885 3272 +2387
Lines 20228 80335 +60107
Branches 3766 16334 +12568
===========================================
+ Hits 11687 39269 +27582
- Misses 7848 36442 +28594
- Partials 693 4624 +3931
Flags with carried forward coverage won't be shown. Click here to find out more. |
name: string; | ||
color: string; | ||
} | ||
export { ILicenseTag } from '@rocket.chat/core-typings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you think that re-exporting everything from the license package again can lead to the same issue? someone importing the typings from the license package instead of the core-typings package.
I'd say to let them there only.
458bc07
to
6eb65fc
Compare
6eb65fc
to
85def9e
Compare
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments