Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @rocket.chat/license from ddp-client deps #31189

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: 1fd0cad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 6.5.1 milestone Dec 7, 2023
@ggazzo ggazzo force-pushed the fix/sdk-license-deps branch from b7cdf2f to 2db46e9 Compare December 7, 2023 20:12
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #31189 (1fd0cad) into develop (f1013a3) will decrease coverage by 8.90%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31189      +/-   ##
===========================================
- Coverage    57.77%   48.88%   -8.90%     
===========================================
  Files          885     3272    +2387     
  Lines        20228    80335   +60107     
  Branches      3766    16334   +12568     
===========================================
+ Hits         11687    39269   +27582     
- Misses        7848    36442   +28594     
- Partials       693     4624    +3931     
Flag Coverage Δ
e2e 51.28% <ø> (+8.91%) ⬆️
e2e-api 40.70% <ø> (?)
unit 77.38% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review December 7, 2023 20:26
@ggazzo ggazzo requested review from a team as code owners December 7, 2023 20:26
name: string;
color: string;
}
export { ILicenseTag } from '@rocket.chat/core-typings';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you think that re-exporting everything from the license package again can lead to the same issue? someone importing the typings from the license package instead of the core-typings package.

I'd say to let them there only.

@ggazzo ggazzo force-pushed the fix/sdk-license-deps branch from 458bc07 to 6eb65fc Compare December 8, 2023 15:12
@ggazzo ggazzo force-pushed the fix/sdk-license-deps branch from 6eb65fc to 85def9e Compare December 8, 2023 15:20
@ggazzo ggazzo requested a review from a team as a code owner December 8, 2023 15:54
@ggazzo ggazzo merged commit c12f15d into develop Dec 8, 2023
42 of 43 checks passed
@ggazzo ggazzo deleted the fix/sdk-license-deps branch December 8, 2023 19:12
@rodrigok rodrigok modified the milestones: 6.5.1, 6.6 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants