Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace useForm in favor of RHF on BusinessHours #31197

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 8, 2023

Proposed changes (including videos or screenshots)

  • Replace useForm in favor of RHF
  • Refactor some components to TS
  • Replace useQuery in favor of useEndpointData
  • Replace deprecated useRoute in favor of useRouter
  • Add a11y support to the forms

Issue(s)

Steps to test or reproduce

Further comments

DSAR-328
DSAR-329
DSAR-334

Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: f04269b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #31197 (f04269b) into develop (f4664f0) will decrease coverage by 8.99%.
The diff coverage is 7.14%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31197      +/-   ##
===========================================
- Coverage    57.88%   48.89%   -8.99%     
===========================================
  Files          886     3270    +2384     
  Lines        20290    80305   +60015     
  Branches      3783    16375   +12592     
===========================================
+ Hits         11744    39268   +27524     
- Misses        7845    36390   +28545     
- Partials       701     4647    +3946     
Flag Coverage Δ
e2e 51.44% <7.14%> (+9.07%) ⬆️
e2e-api 40.64% <ø> (?)
unit 77.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 11, 2023 16:37
@dougfabris dougfabris requested review from a team as code owners December 11, 2023 16:37
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 11, 2023
@kodiakhq kodiakhq bot merged commit a275033 into develop Dec 11, 2023
43 of 44 checks passed
@kodiakhq kodiakhq bot deleted the chore/refactor-businessHour branch December 11, 2023 21:17
@dougfabris dougfabris added this to the 6.6 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants