-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LDAP Group filter doesn't work and throws "No Such Object" error on login #31377
Conversation
🦋 Changeset detectedLatest commit: a47635c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31377 +/- ##
===========================================
- Coverage 49.60% 49.56% -0.04%
===========================================
Files 3308 3312 +4
Lines 81389 81460 +71
Branches 16697 16712 +15
===========================================
+ Hits 40370 40379 +9
- Misses 36328 36370 +42
- Partials 4691 4711 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a new connection, just validate the group before validating the password.
Proposed changes (including videos or screenshots)
Issue(s)
Fixes #15621
Fixes #15069
Steps to test or reproduce
Further comments
TC-1073