Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: hide archived rooms in room.autocomplete endpoint #31383

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

heitortanoue
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue with the create option discussion, the list when you choose the Channel or Group is showing Archived Teams/groups/channels

Issue(s)

Steps to test or reproduce

  • Create at least one channel/group/team and then archive them

  • Choose to create a discussion and then you will be able to pick this archived channel from the drop down suggestion list for parent channel

Further comments

SUP-286

@heitortanoue heitortanoue requested a review from a team as a code owner January 5, 2024 14:51
Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 1cd5c49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heitortanoue heitortanoue marked this pull request as draft January 5, 2024 14:53
@heitortanoue heitortanoue marked this pull request as ready for review January 5, 2024 14:55
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@bb50bda). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #31383   +/-   ##
================================================
  Coverage                 ?   63.35%           
================================================
  Files                    ?     2037           
  Lines                    ?    47592           
  Branches                 ?    11096           
================================================
  Hits                     ?    30154           
  Misses                   ?    15594           
  Partials                 ?     1844           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should consider this a breaking change since this changes the output of the rooms.autocomplete.channelAndPrivate endpoint. I'll approve it for now since it looks fine to me, but I'll mark it as a major change.
Please tell me if you agree, @MarcosSpessatto

@MarcosSpessatto
Copy link
Member

Also, I think we should consider this a breaking change since this changes the output of the rooms.autocomplete.channelAndPrivate endpoint. I'll approve it for now since it looks fine to me, but I'll mark it as a major change. Please tell me if you agree, @MarcosSpessatto

Yes, I agree. Let's keep this as a breaking change then. 👍

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2024
@ggazzo ggazzo changed the title fix: hide archived rooms in room.autocomplete endpoint fix!: hide archived rooms in room.autocomplete endpoint Jan 25, 2024
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Jan 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 26, 2024
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 50abbe6 to bf02ce5 Compare September 27, 2024 22:43
@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the release-7.0.0 branch 8 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
@sampaiodiego sampaiodiego removed the do not merge Prevent a PR from being automatically merged label Oct 15, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31383/
on branch gh-pages at 2024-10-16 11:16 UTC

@ggazzo ggazzo merged commit afb978d into release-7.0.0 Oct 16, 2024
48 of 51 checks passed
@ggazzo ggazzo deleted the fix/room-autocomplete-hide-archived branch October 16, 2024 17:21
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants