-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: hide archived rooms in room.autocomplete endpoint #31383
Conversation
🦋 Changeset detectedLatest commit: 1cd5c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #31383 +/- ##
================================================
Coverage ? 63.35%
================================================
Files ? 2037
Lines ? 47592
Branches ? 11096
================================================
Hits ? 30154
Misses ? 15594
Partials ? 1844
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we should consider this a breaking change since this changes the output of the rooms.autocomplete.channelAndPrivate
endpoint. I'll approve it for now since it looks fine to me, but I'll mark it as a major change.
Please tell me if you agree, @MarcosSpessatto
Yes, I agree. Let's keep this as a breaking change then. 👍 |
50abbe6
to
bf02ce5
Compare
d1aa5f9
to
374979f
Compare
bfefe41
to
204272c
Compare
|
Proposed changes (including videos or screenshots)
Issue with the create option discussion, the list when you choose the Channel or Group is showing Archived Teams/groups/channels
Issue(s)
Steps to test or reproduce
Create at least one channel/group/team and then archive them
Choose to create a discussion and then you will be able to pick this archived channel from the drop down suggestion list for parent channel
Further comments
SUP-286