Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Notifications in favor of sdk.stream; #31409

Merged
merged 21 commits into from
Jan 16, 2024

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(client): Move Meteor overrides (#28366)
  fix: login buttons remain visible until refresh after disabling authentication service (#31371)
@gabriellsh gabriellsh requested a review from a team as a code owner January 9, 2024 19:38
Copy link

changeset-bot bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: a9a2649

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0c3a563) 49.54% compared to head (a9a2649) 59.82%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31409       +/-   ##
============================================
+ Coverage    49.54%   59.82%   +10.28%     
============================================
  Files         3312     1797     -1515     
  Lines        81420    34968    -46452     
  Branches     16702     7276     -9426     
============================================
- Hits         40337    20921    -19416     
+ Misses       36386    12441    -23945     
+ Partials      4697     1606     -3091     
Flag Coverage Δ
e2e 53.16% <79.16%> (+0.03%) ⬆️
e2e-api ?
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(i18n): Translation's lint and load (#31343)
  fix: multiple indexes creations during migrations (#31413)
  feat: add `ImageGallery` zoom controls (#31369)
  chore: internalize flow-router (from meteor 3 branch) (#31365)
  chore: internalize meteor run as user (from meteor 3) (#31370)
  chore: internalize meteor inject initial (from meteor 3) (#31367)
  chore: internalize meteor cookies (from meteor 3) (#31366)
@scuciatto scuciatto added this to the 6.6 milestone Jan 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 16, 2024
@kodiakhq kodiakhq bot merged commit 6526b2f into develop Jan 16, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the remove/Notifications branch January 16, 2024 14:55
gabriellsh added a commit that referenced this pull request Jan 16, 2024
…omni

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor: Replace `Notifications` in favor of `sdk.stream`; (#31409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants