Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Convert emoji shortname to unicode on notification emails #31521

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Fixes undisclosed issue introduced in #31225

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 8071183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (448e35a) 76.47% compared to head (8071183) 76.47%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31521   +/-   ##
========================================
  Coverage    76.47%   76.47%           
========================================
  Files          278      278           
  Lines         9008     9008           
  Branches      1708     1708           
========================================
  Hits          6889     6889           
  Misses        1688     1688           
  Partials       431      431           
Flag Coverage Δ
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit c153fbf into develop Jan 23, 2024
19 checks passed
@ggazzo ggazzo deleted the fix/sendNotification branch January 23, 2024 19:37
@casalsgh casalsgh added this to the 6.6 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants