Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: after-guest-registration being deleted after chat starts #31981

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 13, 2024

introduced here: #31268
PROSVC-37

these two fields were removed so the filter is always returning []
https://github.com/RocketChat/Rocket.Chat/pull/31268/files#diff-d58e67bd7a2a3a9c4635055c0fa8c35b7117d5d9b8aaaad20891f5316b27f51bL142-L143

Proposed changes (including videos or screenshots)

Issue(s)

CORE-195

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: 2c0f044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.45%. Comparing base (6c92d10) to head (2c0f044).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31981   +/-   ##
========================================
  Coverage    54.45%   54.45%           
========================================
  Files         2290     2290           
  Lines        50505    50505           
  Branches     10316    10316           
========================================
  Hits         27501    27501           
- Misses       20506    20536   +30     
+ Partials      2498     2468   -30     
Flag Coverage Δ
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

MartinSchoeler
MartinSchoeler previously approved these changes Mar 13, 2024
@ggazzo ggazzo force-pushed the regression/after-guest-registration branch 5 times, most recently from b99b49d to 827ef83 Compare March 13, 2024 22:50
@ggazzo ggazzo force-pushed the regression/after-guest-registration branch from 827ef83 to 1e08c53 Compare March 13, 2024 22:51
@ggazzo ggazzo marked this pull request as ready for review March 14, 2024 00:27
@ggazzo ggazzo requested review from a team as code owners March 14, 2024 00:27
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 14, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 14, 2024
@ggazzo ggazzo merged commit dc6c572 into develop Mar 14, 2024
18 checks passed
@ggazzo ggazzo deleted the regression/after-guest-registration branch March 14, 2024 13:04
MartinSchoeler pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants