-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New users page pending tab #31987
Conversation
Created a helper function named isSMTPConfigured.ts to run when calling the smtp.check endpoint of the misc.ts group.
Created the two new endpoints that represent the back-end for the new users page.
Added a tab layout to the new users page, created the useFilteredUsers custom hook and implemented it. Also created necessary typing and translation entries.
Added a new column to the users table called registration status that shows the status of the current user. Also created new translation entries.
Added the pending tab to the new users page tab layout and implemented the usePendingUsersCount custom hook to fetch the users count number that will appear on the title of the tab.
🦋 Changeset detectedLatest commit: 7be9720 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31987 +/- ##
===========================================
+ Coverage 56.54% 56.55% +0.01%
===========================================
Files 2484 2487 +3
Lines 54755 54834 +79
Branches 11308 11331 +23
===========================================
+ Hits 30959 31010 +51
- Misses 21113 21129 +16
- Partials 2683 2695 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Added the Pending action column to the users table of the pending tab, removed an unnecessary console.log and added the necessary translation entries to the i18n dictionary.
Implemented an actions section for the users page table with a menu similar to the one inside of the contextual bar and two new buttons exclusiive to the pending tab, an Activate button for admins to quickly activate users and and Resend Welcome Email for admins to remember users to login for the first time. Also changed some typings to better work with the new code and added the necessary translations.
Introduced a new field in the contextual bar on the users page named 'Reason for Joining'. This field will display the text that users entered when creating their accounts, but only if the 'Manually Approve New Users' setting is enabled. Additionally, reorganized the contextual bar to enhance clarity and have included the required translation entries in the i18n dictionary.
Implemented a callout component that will appear once the sets cap is exceeded and disabled the Activate, Invite and New user buttons when exceeded. Also added the necessary new translation entries to the i18n dictionary.
…ocket.Chat into feat/new-user-panel-pending
apps/meteor/ee/client/views/admin/users/UserPageHeaderContentWithSeatsCap.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/users/UsersTable/UsersTableRow.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/users/UsersTable/UsersTableRow.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/users/UsersTable/UsersTableRow.tsx
Outdated
Show resolved
Hide resolved
Improved the algorithm that finds the biggest max limit for the SubscriptionCalloutLimits component improving the overall time complexity of the process from O(nlogn) to O(n).
Created a new hook to expose the logic of the SubscriptionCalloutLimits component to be used externally of the component and implemented a new logic for the user panel callout that better follows the one that already exists.
Proposed changes (including videos or screenshots)
This PR introduces a new pending users tab to the users page and a set of new features:
----------------------------------------- Changes after initial review -------------------------------------------------
This change solves an issue with the standard AJV email validation in which dotless emails were not being accepted.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
Blocked by: #31917
Related to: #30236
Jira: WM-51