-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New users page contextual bar user form #32041
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32041 +/- ##
===========================================
- Coverage 59.40% 59.38% -0.02%
===========================================
Files 2547 2547
Lines 63309 63255 -54
Branches 14248 14228 -20
===========================================
- Hits 37610 37567 -43
+ Misses 22980 22978 -2
+ Partials 2719 2710 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like this PR is ready to merge! 🎉 |
7cb7f3e
to
7d12186
Compare
ede03e6
to
f92f17d
Compare
Implemented the new email field as the first input of the new user form, with the mark email as verified option right bellow it with a new info tooltip explaining what the toggle does. Also added a briefing text at the top of the new user form.
Added the PasswordVerifier component to the password field of the New User form and refactored the field to merge it with the "Set random password and send it by email" option.
Implemented a 'hide/show custom fields' button in the new user form and refactored it to follow new figma specs.
Implemented a new step for the users page user creation contextual bar in which the user will be able to choose from creating another user right away or finishing the user creation process and being redirected to the most recently created user. Also fixed some tests, created new translations and changed some logic to improve the roles filter.
Fixed an issue with the spacing of the MultiSelectCustom Search bar in which unnecessary padding and margin were being applied to the component.
24ec187
to
f9c4fee
Compare
Removed the FilterByText component from the UsersTableFilters component because the Margins component that wraps the children of that component made impossible to control flexGrow and Width in smaller screens.
…l loading states Solved a problem on the initial render of the setRandomPassword, sendWelcomeEmail and Verify email that happened due to the asynchronous nature of the isSmtpEnabled variable. Also improved some boolean verifications and added a useMemo for the availableRoles variable.
Fix UX issues Fixed two copy issues on the texts of the Status message and and user created toast. Also fixed a spacing issue on the Mark Email as Verified field in which the space between the label and the tooltip was too big.
…too small Fixed a bug where the roles filter list wouldn't resize or scroll on smaller screens because it was set to position: absolute. Also, resolved a UI issue where the users table scrollbar appeared on top of the roles filter due to a low z-index on the filter list.
Changed the users table GenericNoResults component to better align with new figma specs.
I replaced the w='50%' property of the buttons on the user-created page with flexBasis='0'. This, combined with the stretch property of the ButtonGroup, ensures that the buttons now occupy exactly half of the available space each
…t/Rocket.Chat into feat/new-user-panel-contextual
Proposed changes (including videos or screenshots)
Refactored User Creation Form:
Other Changes in This PR:
Demo videos:
https://www.loom.com/share/d2dc00a2f2674abb9555e77414944817
https://www.loom.com/share/aad5696db4b0476b9c9520b262d3f192
Issue(s)
Steps to test or reproduce
Further comments
Related to: #30236
Old Jira task: WM-88
New Jira task for Conn: CONN-263