-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Single Contact Identification #32727
Conversation
* feat: add warning deprecation * chore: changeset
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f15ca39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32727 +/- ##
===========================================
+ Coverage 75.18% 75.73% +0.54%
===========================================
Files 495 507 +12
Lines 21600 21799 +199
Branches 5362 5343 -19
===========================================
+ Hits 16241 16509 +268
+ Misses 4717 4648 -69
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
30e5f03
to
a17f84c
Compare
a6769ec
to
2b90fb7
Compare
2b90fb7
to
56c685c
Compare
* chore: remove hidden prop in new settings * feat: new security and privacy page * fix: review * chore: changeset
55d7d46
to
8bdc3ae
Compare
af48113
to
87db6ab
Compare
|
87db6ab
to
3b4509f
Compare
6f62f24
to
536135b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we have problems with patterns and code style decisions that we could do differently, but in theory nothing that interferes with how it works.
apps/meteor/client/views/omnichannel/contactInfo/tabs/ContactInfoDetails/ContactInfoDetails.tsx
Outdated
Show resolved
Hide resolved
283eae4
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-98