Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Single Contact Identification #32727

Merged
merged 207 commits into from
Nov 19, 2024
Merged

feat: Single Contact Identification #32727

merged 207 commits into from
Nov 19, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 5, 2024

Proposed changes (including videos or screenshots)

Kapture 2024-11-29 at 15 07 23

Issue(s)

Steps to test or reproduce

Further comments

SCI-98

Copy link
Contributor

dionisio-bot bot commented Jul 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: f15ca39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps-engine Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 87.42515% with 42 lines in your changes missing coverage. Please review.

Project coverage is 75.73%. Comparing base (b2d864c) to head (283eae4).
Report is 26 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32727      +/-   ##
===========================================
+ Coverage    75.18%   75.73%   +0.54%     
===========================================
  Files          495      507      +12     
  Lines        21600    21799     +199     
  Branches      5362     5343      -19     
===========================================
+ Hits         16241    16509     +268     
+ Misses        4717     4648      -69     
  Partials       642      642              
Flag Coverage Δ
unit 75.73% <87.42%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@dougfabris dougfabris force-pushed the feat/single-contact-id branch 4 times, most recently from 30e5f03 to a17f84c Compare August 8, 2024 13:22
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 2 times, most recently from a6769ec to 2b90fb7 Compare August 19, 2024 20:38
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 2b90fb7 to 56c685c Compare August 20, 2024 14:42
* chore: remove hidden prop in new settings

* feat: new security and privacy page

* fix: review

* chore: changeset
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 55d7d46 to 8bdc3ae Compare August 28, 2024 13:39
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from af48113 to 87db6ab Compare October 4, 2024 14:59
Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-32727/
on branch gh-pages at 2024-11-19 17:32 UTC

@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 87db6ab to 3b4509f Compare October 8, 2024 18:33
@dougfabris dougfabris force-pushed the feat/single-contact-id branch from 6f62f24 to 536135b Compare October 11, 2024 18:51
ggazzo
ggazzo previously approved these changes Nov 19, 2024
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we have problems with patterns and code style decisions that we could do differently, but in theory nothing that interferes with how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.