feat: Allows multiple emails and phone numbers in edit contact info #32900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
8c4961a to
b8f1151
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/search-create-edit #32900 +/- ##
========================================================
Coverage 58.43% 58.43%
========================================================
Files 2743 2743
Lines 66156 66156
Branches 14953 14953
========================================================
Hits 38661 38661
Misses 24678 24678
Partials 2817 2817
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
feat/single-contact-id
branch
3 times, most recently
from
30e5f03 to
a17f84c
Compare
dougfabris
force-pushed
the
feat/single-contact-id
branch
3 times, most recently
from
2b90fb7 to
56c685c
Compare
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
b8f1151 to
d6d4167
Compare
|
dougfabris
force-pushed
the
feat/single-contact-id
branch
3 times, most recently
from
a39f3c8 to
094b155
Compare
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
d6d4167 to
b0c50af
Compare
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
b0c50af to
f05c63a
Compare
dougfabris
changed the base branch from
feat/single-contact-id
to
feat/search-create-edit
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
f05c63a to
2a37506
Compare
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
7aa1469 to
1675935
Compare
dougfabris
force-pushed
the
feat/edit-contact-info
branch
from
1675935 to
7a13b75
Compare
dougfabris
added a commit
that referenced
this pull request
Oct 16, 2024
* feat: get contact data from the new endpoint * feat: allow multiple emails and phone numbers * chore: `ContactManagerInput` to ts * chore: add fields validations
dougfabris
added a commit
that referenced
this pull request
Oct 16, 2024
* feat: Get contacts from `contacts.search` endpoint (#33573) * feat: Allows multiple emails and phones in edit contact info (#32900) * feat: get contact data from the new endpoint * feat: allow multiple emails and phone numbers * chore: `ContactManagerInput` to ts * chore: add fields validations * chore: changeset * chore: remove unnecessary `id` from `EditContactInfo` * chore: skip contact center tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-11