i18n: Required fields text to "{Field} required" format #33077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on text Added a new text for required fields that follows design specifications. Additionally, I updated the Direct_message_creation_error text to better align with the new guidelines.
|
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33077 +/- ##
===========================================
+ Coverage 59.68% 59.71% +0.02%
===========================================
Files 2551 2551
Lines 62819 62823 +4
Branches 14115 14107 -8
===========================================
+ Hits 37496 37515 +19
+ Misses 22908 22901 -7
+ Partials 2415 2407 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Changed all places that used alternative forms of the "The_field_is_required" i18n string to it and refactored some forms to properly use the useForm errors object.
…' and properly implement useForm In addition to updating the required field texts in other forms, this commit includes several refactors: the mode of useForm was changed to 'all', unique IDs were introduced where needed, inputs were refactored to improve the use of the RHF controller, and the disabled attribute was removed from submit buttons
…itDepartment wrong translation Adapted the omnichannel tests to the new required field text and fixed a misuse of the 'The_field_is_required' translation string in which untranslated lowercase strings of the given field name were being passed to the i18n t function.
tassoevan
requested changes
Aug 19, 2024
aleksandernsilva
previously approved these changes
Aug 21, 2024
tassoevan
requested changes
Sep 5, 2024
tassoevan
previously approved these changes
Sep 6, 2024
|
dionisio-bot
bot
added
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
tassoevan
approved these changes
Sep 13, 2024
aleksandernsilva
approved these changes
Sep 13, 2024
rique223
changed the title
rique223
changed the title
KevLehman
pushed a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently, mandatory fields display the following error message in production: 'The field %s is required.' For example: 'The field email is required.' Product has decided to change the format of this message to '%s required' For example: 'Email required' Since this is the default 'Field required' message, updating it across all areas of the system is necessary. This PR aims to address that change.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: CONN-314