Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VoIP Backend for FreeSwitch #33093

Merged
merged 14 commits into from
Sep 16, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR adds a new page on the admin settings where an admin can configure and enable access to a FreeSwitch instance.

It also adds all the endpoints the webclient may need in order to manage freeswitch users and to get the required information to connect a rocket.chat user to VoIP calls.

Issue(s)

VOIP-19
VOIP-20
VOIP-21
VOIP-26
VOIP-32
VOIP-34
VOIP-35
VOIP-38
VOIP-75
VOIP-76
VOIP-77

Steps to test or reproduce

Further comments

New endpoints:

voip-freeswitch.extension.list
voip-freeswitch.extension.getDetails
voip-freeswitch.extension.assign
voip-freeswitch.extension.getRegistrationInfoByUserId

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: 9707926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from develop to feat/freeswitch-6-12 August 19, 2024 20:54
@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.12 milestone Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.76%. Comparing base (811e2cb) to head (9707926).
Report is 1 commits behind head on feat/freeswitch-6-12.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/freeswitch-6-12   #33093      +/-   ##
========================================================
- Coverage                 59.76%   59.76%   -0.01%     
========================================================
  Files                      2551     2553       +2     
  Lines                     63118    63155      +37     
  Branches                  14116    14123       +7     
========================================================
+ Hits                      37720    37742      +22     
- Misses                    22982    22995      +13     
- Partials                   2416     2418       +2     
Flag Coverage Δ
unit 76.92% <29.16%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review August 22, 2024 00:01
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners August 22, 2024 00:01
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a changeset, I assume we will add that on the feature-branch, right @pierre-lehnen-rc ?

apps/meteor/package.json Show resolved Hide resolved
apps/meteor/server/models/raw/Users.js Show resolved Hide resolved
apps/meteor/server/models/raw/Users.js Show resolved Hide resolved
packages/freeswitch/src/utils/parseUserList.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Sep 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-16 18:16 UTC

@pierre-lehnen-rc pierre-lehnen-rc merged commit e7c3afa into feat/freeswitch-6-12 Sep 16, 2024
50 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/freeswitch-backend branch September 16, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants