-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow admins to control if visitors can close omnichannel conversations #33139
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a18669d The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33139 +/- ##
========================================
Coverage 59.32% 59.32%
========================================
Files 2548 2548
Lines 63415 63415
Branches 14268 14268
========================================
Hits 37622 37622
Misses 23090 23090
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Proposed changes (including videos or screenshots)
Visitors have always had the ability of closing ongoing conversations. This, however, means a visitor can close a conversation before it has been served or before an automation process has finished on customer side, which can cause issues.
New setting
Allow visitors to finish conversations
is created with this purpose. By default, the same behavior will be kept, where visitors can close conversations. When the setting is off, visitors won't see the button to close a conversation and the API will throw an error for them. This doesn't affect agent's capabilities of closing conversations.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-632
Steps to test or reproduce
Further comments