Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Handle live setting forget user session on window close update #33150

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 26, 2024

Backport of #33133

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner August 26, 2024 16:43
@dionisio-bot dionisio-bot bot requested a review from yash-rajpal August 26, 2024 16:44
Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: d084963

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Aug 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.10.5@103106f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.5   #33150   +/-   ##
=================================================
  Coverage                  ?   56.60%           
=================================================
  Files                     ?     2504           
  Lines                     ?    55706           
  Branches                  ?    11529           
=================================================
  Hits                      ?    31532           
  Misses                    ?    21478           
  Partials                  ?     2696           
Flag Coverage Δ
e2e 56.43% <100.00%> (?)
unit 71.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 26, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Aug 27, 2024
@kodiakhq kodiakhq bot merged commit 9dfddde into release-6.10.5 Aug 27, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.5-33133 branch August 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants