-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move GenericMenu to ui-client package #33247
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33247 +/- ##
===========================================
+ Coverage 59.73% 59.76% +0.02%
===========================================
Files 2548 2551 +3
Lines 63075 63118 +43
Branches 14090 14116 +26
===========================================
+ Hits 37681 37720 +39
- Misses 22978 22982 +4
Partials 2416 2416
Flags with carried forward coverage won't be shown. Click here to find out more. |
packages/ui-client/src/components/GenericMenu/GenericMenuItem.tsx
Outdated
Show resolved
Hide resolved
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
c19e70d
c366fc2
to
c19e70d
Compare
Proposed changes (including videos or screenshots)
Moved the component
GenericMenu
to the@rocket.chat/ui-client
package and adjusted imports accordingly. This change will allow this component to be used by packages outsideapps/meteor
.