-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved UserAutoComplete to ui-client package #33249
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33249 +/- ##
========================================
Coverage 59.73% 59.73%
========================================
Files 2548 2548
Lines 63075 63075
Branches 14090 14090
========================================
Hits 37681 37681
Misses 22978 22978
Partials 2416 2416
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Proposed changes (including videos or screenshots)
Moved the component
UserAutoComplete
to the@rocket.chat/ui-client
package and adjusted imports accordingly. This change will allow this component to be used by packages outsideapps/meteor
.