Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove info call from wait and call #33276

Closed
wants to merge 2 commits into from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 13, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 03a5b57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 13, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33276/
on branch gh-pages at 2024-10-19 02:10 UTC

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (429d000) to head (03a5b57).
Report is 27 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33276   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21019    21019           
  Branches      5334     5334           
========================================
  Hits         15760    15760           
  Misses        4630     4630           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review September 13, 2024 02:54
@ggazzo ggazzo added this to the 6.13 milestone Sep 13, 2024
@tassoevan tassoevan modified the milestones: 6.13, 6.14 Sep 30, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@KevLehman KevLehman force-pushed the chore/remove-log-info-call-and-wait branch from 89a677a to 44b0fc5 Compare October 18, 2024 20:11
KevLehman
KevLehman previously approved these changes Oct 18, 2024
@ggazzo ggazzo modified the milestones: 7.0, 7.1.0 Oct 21, 2024
@ggazzo ggazzo closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants