fix(federation-v2): don't throw on username validation before creating dm

.changeset/fifty-parrots-wonder.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixed an issue where normal direct message rooms could not be created due to invalid federation configuration.

apps/meteor/server/services/federation/infrastructure/rocket-chat/hooks/index.ts

@@ -74,12 +74,10 @@ export class FederationHooks {
 		callbacks.add(
 			'federation.beforeCreateDirectMessage',
 			async (members: IUser[]): Promise<void> => {
-				if (!members) {
+				if (!members || !isFederationEnabled()) {
 					return;
 				}
 
-				throwIfFederationNotEnabledOrNotReady();
-
 				await callback(members);
 			},
 			callbacks.priority.HIGH,

apps/meteor/tests/unit/server/federation/infrastructure/rocket-chat/hooks/hooks.spec.ts

@@ -279,6 +279,7 @@ describe('Federation - Infrastructure - RocketChat - Hooks', () => {
 		it('should execute the callback when everything is correct', () => {
 			const stub = sinon.stub();
 			FederationHooks.canCreateDirectMessageFromUI(stub);
+			isFederationEnabled.returns(true);
 			hooks['federation-v2-can-create-direct-message-from-ui-ce']([]);
 			expect(stub.calledWith([])).to.be.true;
 		});