-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Allow E2EE rooms to reset its room key #33328
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 9fac813 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0630c43
to
a537433
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33328 +/- ##
==============================================
Coverage 74.69% 74.69%
==============================================
Files 437 437
Lines 20472 20472
Branches 5249 5249
==============================================
Hits 15291 15291
Misses 4569 4569
Partials 612 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
a537433
to
4feaa9f
Compare
abe1570
to
e9bbdbd
Compare
f5879a5
to
cf8dd2a
Compare
e9bbdbd
to
cb512e1
Compare
4a966a9
to
47edda9
Compare
cb512e1
to
335ae33
Compare
f2e9472
to
6dba1b5
Compare
50abbe6
to
bf02ce5
Compare
d923ab6
to
d74cd3d
Compare
a94b9b7
to
d213d6a
Compare
apps/meteor/client/hooks/roomActions/useE2EERoomKeyResetAction.ts
Outdated
Show resolved
Hide resolved
f100dcf
to
b07e81c
Compare
ee0b002
to
adfae35
Compare
ec33e68
to
d1aa5f9
Compare
facad90
to
e9b52ae
Compare
d1aa5f9
to
374979f
Compare
f1a821b
to
fd881cd
Compare
44cb522
to
a0e985d
Compare
apps/meteor/app/e2e/server/functions/provideUsersSuggestedGroupKeys.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]>
Proposed changes (including videos or screenshots)
Allows authorized users to reset the encryption key of E2EE rooms.
The idea is to prevent situations where all users of a room have lost the keys, and with that, have lost the access to use the room. Now Rocket.Chat will allow them to define a new set of keys for the room via UI.
If a user happens to have a key to the room, after the reset this will be moved to a list of
oldRoomKeys
, which the UI will use to decode older messages.Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-64
Steps to test or reproduce
Further comments