Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CreateOAuthModal to use React Hook Form #33347

Merged
merged 12 commits into from
Nov 1, 2024

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Sep 24, 2024

Proposed changes (including videos or screenshots)

Implemented React Hook Form for CreateOAuthModal and implemented accessibility improvements for the component.

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

Jira task: CONN-345

Copy link
Contributor

dionisio-bot bot commented Sep 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: bc4bbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33347/
on branch gh-pages at 2024-11-01 12:49 UTC

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (a219412) to head (bc4bbe1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33347   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files          493      493           
  Lines        21499    21499           
  Branches      5337     5337           
========================================
  Hits         16215    16215           
  Misses        4644     4644           
  Partials       640      640           
Flag Coverage Δ
unit 75.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 modified the milestone: 6.13 Sep 27, 2024
@rique223 rique223 force-pushed the refactor/OAuth-modal-accessibility branch from 99854fe to 912c6e5 Compare October 11, 2024 18:06
…CreateOAuthModal

Implemented React Hook Form for CreateOAuthModal and implemented the first batch of accessibility improvements for the component.
@rique223 rique223 force-pushed the refactor/OAuth-modal-accessibility branch from f9fa18b to f433353 Compare October 19, 2024 00:06
@rique223 rique223 marked this pull request as ready for review October 23, 2024 13:07
@rique223 rique223 requested a review from a team as a code owner October 23, 2024 13:07
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take this opportunity to write unit tests for this modal?

@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Oct 23, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Oct 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 29, 2024
@aleksandernsilva aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 30, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 30, 2024
@aleksandernsilva aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Oct 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 1, 2024
@kodiakhq kodiakhq bot merged commit 6ec240b into develop Nov 1, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the refactor/OAuth-modal-accessibility branch November 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants