-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: CreateOAuthModal to use React Hook Form #33347
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33347 +/- ##
========================================
Coverage 75.42% 75.42%
========================================
Files 493 493
Lines 21499 21499
Branches 5337 5337
========================================
Hits 16215 16215
Misses 4644 4644
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
99854fe
to
912c6e5
Compare
…CreateOAuthModal Implemented React Hook Form for CreateOAuthModal and implemented the first batch of accessibility improvements for the component.
f9fa18b
to
f433353
Compare
…tChat/Rocket.Chat into refactor/OAuth-modal-accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take this opportunity to write unit tests for this modal?
Proposed changes (including videos or screenshots)
Implemented React Hook Form for CreateOAuthModal and implemented accessibility improvements for the component.
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: CONN-345