-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Encrypted push notification missing message.content #33377
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d5a37ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33377 +/- ##
===========================================
+ Coverage 58.43% 59.43% +1.00%
===========================================
Files 2746 2611 -135
Lines 66285 64301 -1984
Branches 15001 14472 -529
===========================================
- Hits 38732 38217 -515
+ Misses 24731 23321 -1410
+ Partials 2822 2763 -59
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Hugo Costa <[email protected]>
Co-authored-by: Hugo Costa <[email protected]>
Co-authored-by: Hugo Costa <[email protected]>
Proposed changes (including videos or screenshots)
We moved
msg
tomessage.content
on #32316This PR sends content on push notification payload, so mobile can decrypt it.
Issue(s)
Steps to test or reproduce
Further comments
Found it while working on RocketChat/Rocket.Chat.ReactNative#5865