i18n: missing pt-BR translation for non-member user mentions

[abhinavkrin]

Proposed changes (including videos or screenshots)

Fix missing translations for mention notifications in pt-BR locale when a user is mentioned but not part of the current channel.

Issue(s)

Steps to test or reproduce

Further comments

CORE-710

[changeset-bot]

⚠️ No Changeset found

Latest commit: f086e08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33413/
on branch gh-pages at 2024-10-17 23:20 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (b338807) to head (f086e08).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #33413       +/-   ##
============================================
- Coverage    74.85%   58.52%   -16.34%     
============================================
  Files          470     2777     +2307     
  Lines        20743    66566    +45823     
  Branches      5294    15037     +9743     
============================================
+ Hits         15528    38957    +23429     
- Misses        4595    24785    +20190     
- Partials       620     2824     +2204     

Flag	Coverage Δ
unit	74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[tiagoevanp]

Suggested change

	"Do_nothing": "Não fazer nada",
	"Do_nothing": "Fazer nada",

[gabriellsh]

I don't think this is a regression. Did anyone test this in older versions to make sure?

Also, the issue reported is not a missing translation. When there is a translation missing, it should always default to the english version (english translation is the base for all other translations, so it is the only one 100% guaranteed to have all keys present, always)

In the attached Jira task the title does indeed just mentions a missing translation, but in the Expected behaviour section there is a mention to how missing translations should be defaulted to english. I understand the confusion.

[jessicaschelly]

Did anyone test this in older versions to make sure?

Yes, on version 6.12.1, it shows the text in English (fallback for missing translation).

The title of the Jira ticket I created may have caused some confusion, I apologize for that. The issue is that the fallback translation is not working properly - if you try the same behavior using languages such as "Belarusian" the problem will still happen. It should use the default language (english) when there's no translation available.

[aleksandernsilva]

@gabriellsh Your points were addressed here #33440

Since the translations itself don't categorize as regression, I am changing this PR's prefix to i18n and milestone to 6.14.

Points were addressed here #33440

yet reviewed

[ggazzo]

why 2 keys with same value and almost same key?