Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Single contact Id settings in routing manager #33490

Merged

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Oct 8, 2024

Proposed changes (including videos or screenshots)

Now, we are using the new settings in order to be sure no agent gets assigned to the visitor that needs to be verified

Issue(s)

Steps to test or reproduce

Further comments

SCI-54

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 569f902

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33490/
on branch gh-pages at 2024-10-18 04:52 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.45%. Comparing base (5e98135) to head (569f902).
Report is 204 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33490       +/-   ##
===========================================================
+ Coverage                   58.43%   74.45%   +16.02%     
===========================================================
  Files                        2744      475     -2269     
  Lines                       66280    21032    -45248     
  Branches                    15001     5354     -9647     
===========================================================
- Hits                        38732    15660    -23072     
+ Misses                      24717     4733    -19984     
+ Partials                     2831      639     -2192     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 74.45% <50.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb changed the title feat: use room manager settings feat: use Single contact Id settings in routing manager Oct 10, 2024
@Gustrb Gustrb marked this pull request as ready for review October 10, 2024 14:03
@Gustrb Gustrb requested review from a team as code owners October 10, 2024 14:03
apps/meteor/app/livechat/server/lib/RoutingManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/RoutingManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/RoutingManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
.changeset/clean-ravens-melt.md Outdated Show resolved Hide resolved
@Gustrb Gustrb requested a review from KevLehman October 13, 2024 14:18
@Gustrb Gustrb added this to the 7.0 milestone Oct 14, 2024
@Gustrb Gustrb requested a review from a team as a code owner October 14, 2024 20:15
@Gustrb Gustrb removed this from the 7.0 milestone Oct 14, 2024
@Gustrb Gustrb changed the base branch from develop to feat/single-contact-id October 15, 2024 21:06
@Gustrb Gustrb force-pushed the feat/use-room-manager-settings branch from 5d55c19 to d654d99 Compare October 15, 2024 21:20
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 16, 2024 13:23
@Gustrb Gustrb force-pushed the feat/use-room-manager-settings branch from 17dd119 to dc1a1fd Compare October 16, 2024 14:47
@MarcosSpessatto MarcosSpessatto removed request for a team October 17, 2024 12:33
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatInquiry.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved
apps/meteor/ee/server/patches/isUnverifiedContact.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Helper.ts Show resolved Hide resolved
@Gustrb Gustrb force-pushed the feat/use-room-manager-settings branch from 61f7ad4 to 1e31245 Compare October 17, 2024 23:08
@pierre-lehnen-rc pierre-lehnen-rc merged commit 90a7e92 into feat/single-contact-id Oct 18, 2024
9 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/use-room-manager-settings branch October 18, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants