Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move Enhanced navigation out of feature preview #33529

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 10, 2024

Proposed changes (including videos or screenshots)

Move Enhanced navigation away from feature preview and make it official SIDE-210

  • delete duplicated Header SIDE-208
  • delete duplicated NavBar
  • delete duplicated sidebar
  • remove newNavigation from feature preview list
  • remove enableQuery from sidepanelNavigation feature
  • adjust tests SIDE-181

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: e6c26cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti changed the title feat: Enhanced navigation feat: move Enhanced navigation out of feature preview Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33529/
on branch gh-pages at 2024-12-23 14:54 UTC

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.24%. Comparing base (c84543f) to head (e6c26cd).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33529      +/-   ##
===========================================
- Coverage    59.28%   59.24%   -0.05%     
===========================================
  Files         2820     2807      -13     
  Lines        67932    67763     -169     
  Branches     15102    15054      -48     
===========================================
- Hits         40275    40147     -128     
+ Misses       24831    24804      -27     
+ Partials      2826     2812      -14     
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 2 times, most recently from 3209752 to 355f259 Compare October 11, 2024 18:10
@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 5 times, most recently from e915fab to f61dae1 Compare December 11, 2024 18:59
@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 4 times, most recently from 789be8e to ea279a1 Compare December 20, 2024 19:08
@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 4 times, most recently from 8a387c9 to 54bc143 Compare December 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant