-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move Enhanced navigation
out of feature preview
#33529
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Enhanced navigation
Enhanced navigation
out of feature preview
a89f4a9
to
ec79a1d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33529 +/- ##
===========================================
- Coverage 59.28% 59.24% -0.05%
===========================================
Files 2820 2807 -13
Lines 67932 67763 -169
Branches 15102 15054 -48
===========================================
- Hits 40275 40147 -128
+ Misses 24831 24804 -27
+ Partials 2826 2812 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
3209752
to
355f259
Compare
e915fab
to
f61dae1
Compare
789be8e
to
ea279a1
Compare
…/HeaderV2` to `client/views/room/Header`
…debar`, `navbar` and `create-room-modal`
test: improve `mark-unread` consistency
8a387c9
to
54bc143
Compare
54bc143
to
784f905
Compare
Proposed changes (including videos or screenshots)
Move
Enhanced navigation
away from feature preview and make it official SIDE-210Header
SIDE-208NavBar
sidebar
newNavigation
from feature preview listenableQuery
fromsidepanelNavigation
featureIssue(s)
Steps to test or reproduce
Further comments